Change in openvpn[release/2.6]: dco: backport immediate notification processing on Linux and FreeBSD
A message that is not in the archive (sent off-list or not yet received): gerrit.1776701747000.I92c5f74a27b40fede204f714b042a6cc80b3703e@...2715...
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1632?usp=email
to review the following change.
Change subject: dco: backport immediate notification processing on Linux and FreeBSD
......................................................................
dco: backport immediate notification processing on Linux and FreeBSD
Backport the immediate DCO message processing model from commit 7791f53 ("dco: process messages immediately after read").
Change the core DCO API from dco_do_read() to dco_read_and_process(), and make the backend read paths own the parsing and immediate handling of kernel notifications before handing the resulting state to process_incoming_dco() or multi_process_incoming_dco().
On Linux, install a permanent netlink callback and process GET_PEER and DEL_PEER messages as they are received, instead of switching callbacks for each read and deferring handling through shared DCO message state. Also add a small guard to avoid requesting peer stats while libnl is still parsing a batch of notifications.
On FreeBSD, move notification handling into dco_read_and_process() and update peer statistics directly from the backend instead of storing temporary byte counters in dco_context_t.
This commit is part of a reworked backport of PR #945 originally proposed by Nikolai Shelekhov <[email protected]...>.
---
M src/openvpn/dco.h
M src/openvpn/dco_freebsd.c
M src/openvpn/dco_freebsd.h
M src/openvpn/dco_linux.c
M src/openvpn/dco_linux.h
M src/openvpn/dco_win.c
M src/openvpn/forward.c
M src/openvpn/forward.h
M src/openvpn/mtcp.c
M src/openvpn/mudp.c
M src/openvpn/multi.c
M src/openvpn/multi.h
12 files changed, 302 insertions(+), 226 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/32/1632/1
src/openvpn/dco.h +4 -3
@@ -128,12 +128,13 @@void close_tun_dco (struct tuntap *tt,openvpn_net_ctx_t *ctx);/** -* Read data from the DCO communication channel (i.e. a control packet) +* Read and process data from the DCO communication channel +* (i.e. a control packet) * * @param dco the DCO context * @return 0 on success or a negative error code otherwise */ -int dco_do_read (dco_context_t *dco); +int dco_read_and_process (dco_context_t *dco);/** * Install a DCO in the main event loop
@@ -300,7 +301,7 @@ }static inline int -dco_do_read (dco_context_t *dco) +dco_read_and_process (dco_context_t *dco) {ASSERT (false);return 0 ;
src/openvpn/dco_freebsd.c +46 -7
96 lines not on this page · raw message
src/openvpn/dco_freebsd.h +3 -2
@@ -33,6 +33,8 @@typedef enum ovpn_key_cipher dco_cipher_t ;enum ovpn_message_type_t { +/* message type #0 is treated as magic number by process_incoming_dco() */ +OVPN_CMD_NO_MESSAGE =0 ,OVPN_CMD_DEL_PEER ,OVPN_CMD_PACKET ,OVPN_CMD_SWAP_KEYS ,
@@ -57,9 +59,8 @@int dco_message_peer_id;int dco_del_peer_reason;struct sockaddr_storage dco_float_peer_ss; + struct context *c; -uint64_t dco_read_bytes; - uint64_t dco_write_bytes; } dco_context_t;#endif /* defined(ENABLE_DCO) && defined(TARGET_FREEBSD) */
src/openvpn/dco_linux.c +225 -178
569 lines not on this page · raw message
src/openvpn/dco_linux.h +1 -2
@@ -44,6 +44,7 @@int status;struct context *c; +int ctrlid;enum ovpn_mode ifmode;
@@ -55,8 +56,6 @@int dco_message_type;int dco_message_peer_id; int dco_del_peer_reason; -uint64_t dco_read_bytes; - uint64_t dco_write_bytes; } dco_context_t;#endif /* defined(ENABLE_DCO) && defined(TARGET_LINUX) */
src/openvpn/dco_win.c +1 -1
@@ -423,7 +423,7 @@ }int -dco_do_read (dco_context_t *dco) +dco_read_and_process (dco_context_t *dco) {/* no-op on windows */ ASSERT (0 );
src/openvpn/forward.c +6 -6
@@ -1269,13 +1269,11 @@ } } -static void -process_incoming_dco (struct context *c) +void +process_incoming_dco (dco_context_t *dco) {#if defined(ENABLE_DCO ) && (defined(TARGET_LINUX ) || defined(TARGET_FREEBSD )) -dco_context_t *dco = &c->c1.tuntap->dco; - -dco_do_read (dco); +struct context *c = dco->c;/* FreeBSD currently sends us removal notifcation with the old peer-id in * p2p mode with the ping timeout reason, so ignore that one to not shoot
@@ -1291,6 +1289,8 @@switch (dco->dco_message_type) {case OVPN_CMD_DEL_PEER : +/* peer is gone, unset ID to prevent more kernel calls */ + c->c2.tls_multi->dco_peer_id =-1 ;if (dco->dco_del_peer_reason ==OVPN_DEL_PEER_REASON_EXPIRED ) { msg(D_DCO_DEBUG, "%s: received peer expired notification of for peer-id "
@@ -2344,7 +2344,7 @@ {if (!IS_SIG (c)) { -process_incoming_dco (c); +dco_read_and_process (&c->c1.tuntap->dco); } } }
src/openvpn/forward.h +7 -0
@@ -50,6 +50,7 @@#include "openvpn.h" #include "occ.h" #include "ping.h" +#include "dco.h" #define IOW_TO_TUN (1<<0)#define IOW_TO_LINK (1<<1)
@@ -248,6 +249,12 @@*/ void process_incoming_tun (struct context *c); +/** +* Process an incoming DCO message (from kernel space). +* +* @param dco - Pointer to the structure representing the DCO context. +*/ +void process_incoming_dco (dco_context_t *dco);/** * Write a packet to the virtual tun/tap network interface.
src/openvpn/mtcp.c +1 -1
@@ -747,7 +747,7 @@/* incoming data on DCO? */ else if (e->arg == MTCP_DCO) { -multi_process_incoming_dco (m); +dco_read_and_process (&m->top.c1.tuntap->dco); }#endif /* signal received? */
src/openvpn/mudp.c +1 -5
@@ -409,11 +409,7 @@ {if (!IS_SIG (&m->top)) { -bool ret = true; -while (ret) - { - ret =multi_process_incoming_dco (m); - } +dco_read_and_process (&m->top.c1.tuntap->dco); } }#endif
src/openvpn/multi.c +5 -15
@@ -3287,20 +3287,17 @@* installed, and we do not need to clean up the state in the kernel */ mi->context.c2.tls_multi->dco_peer_id =-1 ; mi->context.sig->signal_text = reason; - mi->context.c2.dco_read_bytes = dco->dco_read_bytes; - mi->context.c2.dco_write_bytes = dco->dco_write_bytes;multi_signal_instance (m, mi,SIGTERM ); } -bool -multi_process_incoming_dco (struct multi_context *m) +void +multi_process_incoming_dco (dco_context_t *dco) { -dco_context_t *dco = &m->top.c1.tuntap->dco; +ASSERT (dco->c->multi); +struct multi_context *m = dco->c->multi;struct multi_instance *mi =NULL ; -int ret =dco_do_read (&m->top.c1.tuntap->dco); -int peer_id = dco->dco_message_peer_id;/* no peer-specific message delivered -> nothing to process.
@@ -3308,7 +3305,7 @@*/ if (peer_id <0 ) { -return ret >0 ; +return ; }if ((peer_id < m->max_clients) && (m->instances[peer_id]))
@@ -3355,13 +3352,6 @@"type %d, del_peer_reason %d" , peer_id, dco->dco_message_type, dco->dco_del_peer_reason); } - - dco->dco_message_type =0 ; - dco->dco_message_peer_id =-1 ; - dco->dco_del_peer_reason =-1 ; - dco->dco_read_bytes =0 ; - dco->dco_write_bytes =0 ; -return ret >0 ; }#endif /* if defined(ENABLE_DCO) && defined(TARGET_LINUX) */
src/openvpn/multi.h +2 -6
@@ -317,13 +317,9 @@/** * Process an incoming DCO message (from kernel space). * -* @param m - The single \c multi_context structur.e -* -* @return -* - True, if the message was received correctly. -* - False, if there was an error while reading the message. +* @param dco - The DCO context containing the parsed message. */ -bool multi_process_incoming_dco (struct multi_context *m); +void multi_process_incoming_dco (dco_context_t *dco);/**************************************************************************/ /**
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1632?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: release/2.6
Gerrit-Change-Id: I92c5f74a27b40fede204f714b042a6cc80b3703e
Gerrit-Change-Number: 1632
Gerrit-PatchSet: 1
Gerrit-Owner: ralf_lici <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1632?usp=email
to look at the new patch set (#2).
Change subject: dco: backport immediate notification processing on Linux and FreeBSD
......................................................................
dco: backport immediate notification processing on Linux and FreeBSD
Backport the immediate DCO message processing model from commit 7791f53 ("dco: process messages immediately after read").
Change the core DCO API from dco_do_read() to dco_read_and_process(), and make the backend read paths own the parsing and immediate handling of kernel notifications before handing the resulting state to process_incoming_dco() or multi_process_incoming_dco().
On Linux, install a permanent netlink callback and process GET_PEER and DEL_PEER messages as they are received, instead of switching callbacks for each read and deferring handling through shared DCO message state. Also add a small guard to avoid requesting peer stats while libnl is still parsing a batch of notifications.
On FreeBSD, move notification handling into dco_read_and_process() and update peer statistics directly from the backend instead of storing temporary byte counters in dco_context_t.
This commit is part of a reworked backport of PR #945 originally proposed by Nikolai Shelekhov <[email protected]...>.
---
M src/openvpn/dco.h
M src/openvpn/dco_freebsd.c
M src/openvpn/dco_freebsd.h
M src/openvpn/dco_linux.c
M src/openvpn/dco_linux.h
M src/openvpn/dco_win.c
M src/openvpn/forward.c
M src/openvpn/forward.h
M src/openvpn/mtcp.c
M src/openvpn/mudp.c
M src/openvpn/multi.c
M src/openvpn/multi.h
12 files changed, 299 insertions(+), 242 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/32/1632/2
src/openvpn/dco.h +4 -3
@@ -128,12 +128,13 @@void close_tun_dco (struct tuntap *tt,openvpn_net_ctx_t *ctx);/** -* Read data from the DCO communication channel (i.e. a control packet) +* Read and process data from the DCO communication channel +* (i.e. a control packet) * * @param dco the DCO context * @return 0 on success or a negative error code otherwise */ -int dco_do_read (dco_context_t *dco); +int dco_read_and_process (dco_context_t *dco);/** * Install a DCO in the main event loop
@@ -300,7 +301,7 @@ }static inline int -dco_do_read (dco_context_t *dco) +dco_read_and_process (dco_context_t *dco) {ASSERT (false);return 0 ;
src/openvpn/dco_freebsd.c +43 -23
112 lines not on this page · raw message
src/openvpn/dco_freebsd.h +3 -2
@@ -33,6 +33,8 @@typedef enum ovpn_key_cipher dco_cipher_t ;enum ovpn_message_type_t { +/* message type #0 is treated as magic number by process_incoming_dco() */ +OVPN_CMD_NO_MESSAGE =0 ,OVPN_CMD_DEL_PEER ,OVPN_CMD_PACKET ,OVPN_CMD_SWAP_KEYS ,
@@ -57,9 +59,8 @@int dco_message_peer_id;int dco_del_peer_reason;struct sockaddr_storage dco_float_peer_ss; + struct context *c; -uint64_t dco_read_bytes; - uint64_t dco_write_bytes; } dco_context_t;#endif /* defined(ENABLE_DCO) && defined(TARGET_FREEBSD) */
src/openvpn/dco_linux.c +225 -178
569 lines not on this page · raw message
src/openvpn/dco_linux.h +1 -2
@@ -44,6 +44,7 @@int status;struct context *c; +int ctrlid;enum ovpn_mode ifmode;
@@ -55,8 +56,6 @@int dco_message_type;int dco_message_peer_id; int dco_del_peer_reason; -uint64_t dco_read_bytes; - uint64_t dco_write_bytes; } dco_context_t;#endif /* defined(ENABLE_DCO) && defined(TARGET_LINUX) */
src/openvpn/dco_win.c +1 -1
@@ -423,7 +423,7 @@ }int -dco_do_read (dco_context_t *dco) +dco_read_and_process (dco_context_t *dco) {/* no-op on windows */ ASSERT (0 );
src/openvpn/forward.c +6 -6
@@ -1269,13 +1269,11 @@ } } -static void -process_incoming_dco (struct context *c) +void +process_incoming_dco (dco_context_t *dco) {#if defined(ENABLE_DCO ) && (defined(TARGET_LINUX ) || defined(TARGET_FREEBSD )) -dco_context_t *dco = &c->c1.tuntap->dco; - -dco_do_read (dco); +struct context *c = dco->c;/* FreeBSD currently sends us removal notifcation with the old peer-id in * p2p mode with the ping timeout reason, so ignore that one to not shoot
@@ -1291,6 +1289,8 @@switch (dco->dco_message_type) {case OVPN_CMD_DEL_PEER : +/* peer is gone, unset ID to prevent more kernel calls */ + c->c2.tls_multi->dco_peer_id =-1 ;if (dco->dco_del_peer_reason ==OVPN_DEL_PEER_REASON_EXPIRED ) { msg(D_DCO_DEBUG, "%s: received peer expired notification of for peer-id "
@@ -2344,7 +2344,7 @@ {if (!IS_SIG (c)) { -process_incoming_dco (c); +dco_read_and_process (&c->c1.tuntap->dco); } } }
src/openvpn/forward.h +7 -0
@@ -50,6 +50,7 @@#include "openvpn.h" #include "occ.h" #include "ping.h" +#include "dco.h" #define IOW_TO_TUN (1<<0)#define IOW_TO_LINK (1<<1)
@@ -248,6 +249,12 @@*/ void process_incoming_tun (struct context *c); +/** +* Process an incoming DCO message (from kernel space). +* +* @param dco - Pointer to the structure representing the DCO context. +*/ +void process_incoming_dco (dco_context_t *dco);/** * Write a packet to the virtual tun/tap network interface.
src/openvpn/mtcp.c +1 -1
@@ -747,7 +747,7 @@/* incoming data on DCO? */ else if (e->arg == MTCP_DCO) { -multi_process_incoming_dco (m); +dco_read_and_process (&m->top.c1.tuntap->dco); }#endif /* signal received? */
src/openvpn/mudp.c +1 -5
@@ -409,11 +409,7 @@ {if (!IS_SIG (&m->top)) { -bool ret = true; -while (ret) - { - ret =multi_process_incoming_dco (m); - } +dco_read_and_process (&m->top.c1.tuntap->dco); } }#endif
src/openvpn/multi.c +5 -15
@@ -3287,20 +3287,17 @@* installed, and we do not need to clean up the state in the kernel */ mi->context.c2.tls_multi->dco_peer_id =-1 ; mi->context.sig->signal_text = reason; - mi->context.c2.dco_read_bytes = dco->dco_read_bytes; - mi->context.c2.dco_write_bytes = dco->dco_write_bytes;multi_signal_instance (m, mi,SIGTERM ); } -bool -multi_process_incoming_dco (struct multi_context *m) +void +multi_process_incoming_dco (dco_context_t *dco) { -dco_context_t *dco = &m->top.c1.tuntap->dco; +ASSERT (dco->c->multi); +struct multi_context *m = dco->c->multi;struct multi_instance *mi =NULL ; -int ret =dco_do_read (&m->top.c1.tuntap->dco); -int peer_id = dco->dco_message_peer_id;/* no peer-specific message delivered -> nothing to process.
@@ -3308,7 +3305,7 @@*/ if (peer_id <0 ) { -return ret >0 ; +return ; }if ((peer_id < m->max_clients) && (m->instances[peer_id]))
@@ -3355,13 +3352,6 @@"type %d, del_peer_reason %d" , peer_id, dco->dco_message_type, dco->dco_del_peer_reason); } - - dco->dco_message_type =0 ; - dco->dco_message_peer_id =-1 ; - dco->dco_del_peer_reason =-1 ; - dco->dco_read_bytes =0 ; - dco->dco_write_bytes =0 ; -return ret >0 ; }#endif /* if defined(ENABLE_DCO) && defined(TARGET_LINUX) */
src/openvpn/multi.h +2 -6
@@ -317,13 +317,9 @@/** * Process an incoming DCO message (from kernel space). * -* @param m - The single \c multi_context structur.e -* -* @return -* - True, if the message was received correctly. -* - False, if there was an error while reading the message. +* @param dco - The DCO context containing the parsed message. */ -bool multi_process_incoming_dco (struct multi_context *m); +void multi_process_incoming_dco (dco_context_t *dco);/**************************************************************************/ /**
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1632?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: release/2.6
Gerrit-Change-Id: I92c5f74a27b40fede204f714b042a6cc80b3703e
Gerrit-Change-Number: 1632
Gerrit-PatchSet: 2
Gerrit-Owner: ralf_lici <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Attention is currently required from: plaisthos, ralf_lici.
cron2 has posted comments on this change by ralf_lici. ( http://gerrit.openvpn.net/c/openvpn/+/1632?usp=email )
Change subject: dco: backport immediate notification processing on Linux and FreeBSD
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1632?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: release/2.6
Gerrit-Change-Id: I92c5f74a27b40fede204f714b042a6cc80b3703e
Gerrit-Change-Number: 1632
Gerrit-PatchSet: 2
Gerrit-Owner: ralf_lici <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: ralf_lici <[email protected]...>
Gerrit-Comment-Date: Tue, 21 Apr 2026 08:48:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
PATCH v2 1/1 dco: backport immediate notification processing on Linux and FreeBSD
In reply to a message not in the archiveFrom: Ralf Lici <[email protected]...>
Backport the immediate DCO message processing model from commit 7791f53 ("dco: process messages immediately after read").
Change the core DCO API from dco_do_read() to dco_read_and_process(), and make the backend read paths own the parsing and immediate handling of kernel notifications before handing the resulting state to process_incoming_dco() or multi_process_incoming_dco().
On Linux, install a permanent netlink callback and process GET_PEER and DEL_PEER messages as they are received, instead of switching callbacks for each read and deferring handling through shared DCO message state. Also add a small guard to avoid requesting peer stats while libnl is still parsing a batch of notifications.
On FreeBSD, move notification handling into dco_read_and_process() and update peer statistics directly from the backend instead of storing temporary byte counters in dco_context_t.
This commit is part of a reworked backport of PR #945 originally proposed by Nikolai Shelekhov <[email protected]...>.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1632
---
This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to release/2.6.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1632
This mail reflects revision 2 of this Change.
Acked-by according to Gerrit (reflected above):
Gert Doering <[email protected]...>
src/openvpn/dco.h +4 -3
@@ -128,12 +128,13 @@void close_tun_dco (struct tuntap *tt,openvpn_net_ctx_t *ctx);/** -* Read data from the DCO communication channel (i.e. a control packet) +* Read and process data from the DCO communication channel +* (i.e. a control packet) * * @param dco the DCO context * @return 0 on success or a negative error code otherwise */ -int dco_do_read (dco_context_t *dco); +int dco_read_and_process (dco_context_t *dco);/** * Install a DCO in the main event loop
@@ -300,7 +301,7 @@ }static inline int -dco_do_read (dco_context_t *dco) +dco_read_and_process (dco_context_t *dco) {ASSERT (false);return 0 ;
src/openvpn/dco_freebsd.c +43 -23
112 lines not on this page · raw message
src/openvpn/dco_freebsd.h +3 -2
@@ -33,6 +33,8 @@typedef enum ovpn_key_cipher dco_cipher_t ;enum ovpn_message_type_t { +/* message type #0 is treated as magic number by process_incoming_dco() */ +OVPN_CMD_NO_MESSAGE =0 ,OVPN_CMD_DEL_PEER ,OVPN_CMD_PACKET ,OVPN_CMD_SWAP_KEYS ,
@@ -57,9 +59,8 @@int dco_message_peer_id;int dco_del_peer_reason;struct sockaddr_storage dco_float_peer_ss; + struct context *c; -uint64_t dco_read_bytes; - uint64_t dco_write_bytes; } dco_context_t;#endif /* defined(ENABLE_DCO) && defined(TARGET_FREEBSD) */
src/openvpn/dco_linux.c +225 -178
569 lines not on this page · raw message
src/openvpn/dco_linux.h +1 -2
@@ -44,6 +44,7 @@int status;struct context *c; +int ctrlid;enum ovpn_mode ifmode;
@@ -55,8 +56,6 @@int dco_message_type;int dco_message_peer_id; int dco_del_peer_reason; -uint64_t dco_read_bytes; - uint64_t dco_write_bytes; } dco_context_t;#endif /* defined(ENABLE_DCO) && defined(TARGET_LINUX) */
src/openvpn/dco_win.c +1 -1
@@ -423,7 +423,7 @@ }int -dco_do_read (dco_context_t *dco) +dco_read_and_process (dco_context_t *dco) {/* no-op on windows */ ASSERT (0 );
src/openvpn/forward.c +6 -6
@@ -1269,13 +1269,11 @@ } } -static void -process_incoming_dco (struct context *c) +void +process_incoming_dco (dco_context_t *dco) {#if defined(ENABLE_DCO ) && (defined(TARGET_LINUX ) || defined(TARGET_FREEBSD )) -dco_context_t *dco = &c->c1.tuntap->dco; - -dco_do_read (dco); +struct context *c = dco->c;/* FreeBSD currently sends us removal notifcation with the old peer-id in * p2p mode with the ping timeout reason, so ignore that one to not shoot
@@ -1291,6 +1289,8 @@switch (dco->dco_message_type) {case OVPN_CMD_DEL_PEER : +/* peer is gone, unset ID to prevent more kernel calls */ + c->c2.tls_multi->dco_peer_id =-1 ;if (dco->dco_del_peer_reason ==OVPN_DEL_PEER_REASON_EXPIRED ) { msg(D_DCO_DEBUG, "%s: received peer expired notification of for peer-id "
@@ -2344,7 +2344,7 @@ {if (!IS_SIG (c)) { -process_incoming_dco (c); +dco_read_and_process (&c->c1.tuntap->dco); } } }
src/openvpn/forward.h +7 -0
@@ -50,6 +50,7 @@#include "openvpn.h" #include "occ.h" #include "ping.h" +#include "dco.h" #define IOW_TO_TUN (1<<0)#define IOW_TO_LINK (1<<1)
@@ -248,6 +249,12 @@*/ void process_incoming_tun (struct context *c); +/** +* Process an incoming DCO message (from kernel space). +* +* @param dco - Pointer to the structure representing the DCO context. +*/ +void process_incoming_dco (dco_context_t *dco);/** * Write a packet to the virtual tun/tap network interface.
src/openvpn/mtcp.c +1 -1
@@ -747,7 +747,7 @@/* incoming data on DCO? */ else if (e->arg == MTCP_DCO) { -multi_process_incoming_dco (m); +dco_read_and_process (&m->top.c1.tuntap->dco); }#endif /* signal received? */
src/openvpn/mudp.c +1 -5
@@ -409,11 +409,7 @@ {if (!IS_SIG (&m->top)) { -bool ret = true; -while (ret) - { - ret =multi_process_incoming_dco (m); - } +dco_read_and_process (&m->top.c1.tuntap->dco); } }#endif
src/openvpn/multi.c +5 -15
@@ -3287,20 +3287,17 @@* installed, and we do not need to clean up the state in the kernel */ mi->context.c2.tls_multi->dco_peer_id =-1 ; mi->context.sig->signal_text = reason; - mi->context.c2.dco_read_bytes = dco->dco_read_bytes; - mi->context.c2.dco_write_bytes = dco->dco_write_bytes;multi_signal_instance (m, mi,SIGTERM ); } -bool -multi_process_incoming_dco (struct multi_context *m) +void +multi_process_incoming_dco (dco_context_t *dco) { -dco_context_t *dco = &m->top.c1.tuntap->dco; +ASSERT (dco->c->multi); +struct multi_context *m = dco->c->multi;struct multi_instance *mi =NULL ; -int ret =dco_do_read (&m->top.c1.tuntap->dco); -int peer_id = dco->dco_message_peer_id;/* no peer-specific message delivered -> nothing to process.
@@ -3308,7 +3305,7 @@*/ if (peer_id <0 ) { -return ret >0 ; +return ; }if ((peer_id < m->max_clients) && (m->instances[peer_id]))
@@ -3355,13 +3352,6 @@"type %d, del_peer_reason %d" , peer_id, dco->dco_message_type, dco->dco_del_peer_reason); } - - dco->dco_message_type =0 ; - dco->dco_message_peer_id =-1 ; - dco->dco_del_peer_reason =-1 ; - dco->dco_read_bytes =0 ; - dco->dco_write_bytes =0 ; -return ret >0 ; }#endif /* if defined(ENABLE_DCO) && defined(TARGET_LINUX) */
src/openvpn/multi.h +2 -6
@@ -317,13 +317,9 @@/** * Process an incoming DCO message (from kernel space). * -* @param m - The single \c multi_context structur.e -* -* @return -* - True, if the message was received correctly. -* - False, if there was an error while reading the message. +* @param dco - The DCO context containing the parsed message. */ -bool multi_process_incoming_dco (struct multi_context *m); +void multi_process_incoming_dco (dco_context_t *dco);/**************************************************************************/ /**
[Openvpn-devel] [PATCH applied] Re: dco: backport immediate notification processing on Linux and FreeBSD
As the commit message says, this is a backport from the revised notification handling in 2.7/master to the old DCO code - the relevant parts are basically the same, the underlying problem is as well (incoming peer stats messages can get intermixed with peer timeout messages, which get then ignored because "we're not interested in that right now", and subsequently userland and kernel disagree on the state of affected peers...)
I've subjected this to full client/server tests on FreeBSD and Linux, with and without DCO, and things work as expected.
The Linux side was further subjected to a Gremlin Horde Attach - namely, many 1000s of very short-lived OpenVPN connects/disconnects, up to 100 in parallel, which is very good in exposing race conditions in event handling. The server did what this patch wants to achieve - do proper cleanup, do proper logging, do not overcount clients, very good.
Your patch has been applied to the release/2.6 branch.
commit e78a8af2f5ce5ef3bbfefc2dc8efeca84027c018
Author: Ralf Lici Date: Tue Apr 21 10:49:01 2026 +0200
dco: backport immediate notification processing on Linux and FreeBSD
Signed-off-by: Ralf Lici <[email protected]...>
Acked-by: Gert Doering <[email protected]...>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1632
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg36707.html
Signed-off-by: Gert Doering <[email protected]...>--
kind regards,
Gert Doering
cron2 has uploaded a new patch set (#3) to the change originally created by ralf_lici. ( http://gerrit.openvpn.net/c/openvpn/+/1632?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: dco: backport immediate notification processing on Linux and FreeBSD
......................................................................
dco: backport immediate notification processing on Linux and FreeBSD
Backport the immediate DCO message processing model from commit 7791f53 ("dco: process messages immediately after read").
Change the core DCO API from dco_do_read() to dco_read_and_process(), and make the backend read paths own the parsing and immediate handling of kernel notifications before handing the resulting state to process_incoming_dco() or multi_process_incoming_dco().
On Linux, install a permanent netlink callback and process GET_PEER and DEL_PEER messages as they are received, instead of switching callbacks for each read and deferring handling through shared DCO message state. Also add a small guard to avoid requesting peer stats while libnl is still parsing a batch of notifications.
On FreeBSD, move notification handling into dco_read_and_process() and update peer statistics directly from the backend instead of storing temporary byte counters in dco_context_t.
This commit is part of a reworked backport of PR #945 originally proposed by Nikolai Shelekhov <[email protected]...>.
Github: OpenVPN/openvpn#900
Github: OpenVPN/openvpn#918
Github: OpenVPN/openvpn#931
Github: fixes OpenVPN/openvpn#919
Github: closes OpenVPN/openvpn#945
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1632
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg36707.html
---
M src/openvpn/dco.h
M src/openvpn/dco_freebsd.c
M src/openvpn/dco_freebsd.h
M src/openvpn/dco_linux.c
M src/openvpn/dco_linux.h
M src/openvpn/dco_win.c
M src/openvpn/forward.c
M src/openvpn/forward.h
M src/openvpn/mtcp.c
M src/openvpn/mudp.c
M src/openvpn/multi.c
M src/openvpn/multi.h
12 files changed, 299 insertions(+), 242 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/32/1632/3
src/openvpn/dco.h +4 -3
@@ -128,12 +128,13 @@void close_tun_dco (struct tuntap *tt,openvpn_net_ctx_t *ctx);/** -* Read data from the DCO communication channel (i.e. a control packet) +* Read and process data from the DCO communication channel +* (i.e. a control packet) * * @param dco the DCO context * @return 0 on success or a negative error code otherwise */ -int dco_do_read (dco_context_t *dco); +int dco_read_and_process (dco_context_t *dco);/** * Install a DCO in the main event loop
@@ -300,7 +301,7 @@ }static inline int -dco_do_read (dco_context_t *dco) +dco_read_and_process (dco_context_t *dco) {ASSERT (false);return 0 ;
src/openvpn/dco_freebsd.c +43 -23
112 lines not on this page · raw message
src/openvpn/dco_freebsd.h +3 -2
@@ -33,6 +33,8 @@typedef enum ovpn_key_cipher dco_cipher_t ;enum ovpn_message_type_t { +/* message type #0 is treated as magic number by process_incoming_dco() */ +OVPN_CMD_NO_MESSAGE =0 ,OVPN_CMD_DEL_PEER ,OVPN_CMD_PACKET ,OVPN_CMD_SWAP_KEYS ,
@@ -57,9 +59,8 @@int dco_message_peer_id;int dco_del_peer_reason;struct sockaddr_storage dco_float_peer_ss; + struct context *c; -uint64_t dco_read_bytes; - uint64_t dco_write_bytes; } dco_context_t;#endif /* defined(ENABLE_DCO) && defined(TARGET_FREEBSD) */
src/openvpn/dco_linux.c +225 -178
569 lines not on this page · raw message
src/openvpn/dco_linux.h +1 -2
@@ -44,6 +44,7 @@int status;struct context *c; +int ctrlid;enum ovpn_mode ifmode;
@@ -55,8 +56,6 @@int dco_message_type;int dco_message_peer_id; int dco_del_peer_reason; -uint64_t dco_read_bytes; - uint64_t dco_write_bytes; } dco_context_t;#endif /* defined(ENABLE_DCO) && defined(TARGET_LINUX) */
src/openvpn/dco_win.c +1 -1
@@ -423,7 +423,7 @@ }int -dco_do_read (dco_context_t *dco) +dco_read_and_process (dco_context_t *dco) {/* no-op on windows */ ASSERT (0 );
src/openvpn/forward.c +6 -6
@@ -1269,13 +1269,11 @@ } } -static void -process_incoming_dco (struct context *c) +void +process_incoming_dco (dco_context_t *dco) {#if defined(ENABLE_DCO ) && (defined(TARGET_LINUX ) || defined(TARGET_FREEBSD )) -dco_context_t *dco = &c->c1.tuntap->dco; - -dco_do_read (dco); +struct context *c = dco->c;/* FreeBSD currently sends us removal notifcation with the old peer-id in * p2p mode with the ping timeout reason, so ignore that one to not shoot
@@ -1291,6 +1289,8 @@switch (dco->dco_message_type) {case OVPN_CMD_DEL_PEER : +/* peer is gone, unset ID to prevent more kernel calls */ + c->c2.tls_multi->dco_peer_id =-1 ;if (dco->dco_del_peer_reason ==OVPN_DEL_PEER_REASON_EXPIRED ) { msg(D_DCO_DEBUG, "%s: received peer expired notification of for peer-id "
@@ -2344,7 +2344,7 @@ {if (!IS_SIG (c)) { -process_incoming_dco (c); +dco_read_and_process (&c->c1.tuntap->dco); } } }
src/openvpn/forward.h +7 -0
@@ -50,6 +50,7 @@#include "openvpn.h" #include "occ.h" #include "ping.h" +#include "dco.h" #define IOW_TO_TUN (1<<0)#define IOW_TO_LINK (1<<1)
@@ -248,6 +249,12 @@*/ void process_incoming_tun (struct context *c); +/** +* Process an incoming DCO message (from kernel space). +* +* @param dco - Pointer to the structure representing the DCO context. +*/ +void process_incoming_dco (dco_context_t *dco);/** * Write a packet to the virtual tun/tap network interface.
src/openvpn/mtcp.c +1 -1
@@ -747,7 +747,7 @@/* incoming data on DCO? */ else if (e->arg == MTCP_DCO) { -multi_process_incoming_dco (m); +dco_read_and_process (&m->top.c1.tuntap->dco); }#endif /* signal received? */
src/openvpn/mudp.c +1 -5
@@ -409,11 +409,7 @@ {if (!IS_SIG (&m->top)) { -bool ret = true; -while (ret) - { - ret =multi_process_incoming_dco (m); - } +dco_read_and_process (&m->top.c1.tuntap->dco); } }#endif
src/openvpn/multi.c +5 -15
@@ -3287,20 +3287,17 @@* installed, and we do not need to clean up the state in the kernel */ mi->context.c2.tls_multi->dco_peer_id =-1 ; mi->context.sig->signal_text = reason; - mi->context.c2.dco_read_bytes = dco->dco_read_bytes; - mi->context.c2.dco_write_bytes = dco->dco_write_bytes;multi_signal_instance (m, mi,SIGTERM ); } -bool -multi_process_incoming_dco (struct multi_context *m) +void +multi_process_incoming_dco (dco_context_t *dco) { -dco_context_t *dco = &m->top.c1.tuntap->dco; +ASSERT (dco->c->multi); +struct multi_context *m = dco->c->multi;struct multi_instance *mi =NULL ; -int ret =dco_do_read (&m->top.c1.tuntap->dco); -int peer_id = dco->dco_message_peer_id;/* no peer-specific message delivered -> nothing to process.
@@ -3308,7 +3305,7 @@*/ if (peer_id <0 ) { -return ret >0 ; +return ; }if ((peer_id < m->max_clients) && (m->instances[peer_id]))
@@ -3355,13 +3352,6 @@"type %d, del_peer_reason %d" , peer_id, dco->dco_message_type, dco->dco_del_peer_reason); } - - dco->dco_message_type =0 ; - dco->dco_message_peer_id =-1 ; - dco->dco_del_peer_reason =-1 ; - dco->dco_read_bytes =0 ; - dco->dco_write_bytes =0 ; -return ret >0 ; }#endif /* if defined(ENABLE_DCO) && defined(TARGET_LINUX) */
src/openvpn/multi.h +2 -6
@@ -317,13 +317,9 @@/** * Process an incoming DCO message (from kernel space). * -* @param m - The single \c multi_context structur.e -* -* @return -* - True, if the message was received correctly. -* - False, if there was an error while reading the message. +* @param dco - The DCO context containing the parsed message. */ -bool multi_process_incoming_dco (struct multi_context *m); +void multi_process_incoming_dco (dco_context_t *dco);/**************************************************************************/ /**
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1632?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: release/2.6
Gerrit-Change-Id: I92c5f74a27b40fede204f714b042a6cc80b3703e
Gerrit-Change-Number: 1632
Gerrit-PatchSet: 3
Gerrit-Owner: ralf_lici <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1632?usp=email )
Change subject: dco: backport immediate notification processing on Linux and FreeBSD
......................................................................
dco: backport immediate notification processing on Linux and FreeBSD
Backport the immediate DCO message processing model from commit 7791f53 ("dco: process messages immediately after read").
Change the core DCO API from dco_do_read() to dco_read_and_process(), and make the backend read paths own the parsing and immediate handling of kernel notifications before handing the resulting state to process_incoming_dco() or multi_process_incoming_dco().
On Linux, install a permanent netlink callback and process GET_PEER and DEL_PEER messages as they are received, instead of switching callbacks for each read and deferring handling through shared DCO message state. Also add a small guard to avoid requesting peer stats while libnl is still parsing a batch of notifications.
On FreeBSD, move notification handling into dco_read_and_process() and update peer statistics directly from the backend instead of storing temporary byte counters in dco_context_t.
This commit is part of a reworked backport of PR #945 originally proposed by Nikolai Shelekhov <[email protected]...>.
Github: OpenVPN/openvpn#900
Github: OpenVPN/openvpn#918
Github: OpenVPN/openvpn#931
Github: fixes OpenVPN/openvpn#919
Github: closes OpenVPN/openvpn#945
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1632
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg36707.html
---
M src/openvpn/dco.h
M src/openvpn/dco_freebsd.c
M src/openvpn/dco_freebsd.h
M src/openvpn/dco_linux.c
M src/openvpn/dco_linux.h
M src/openvpn/dco_win.c
M src/openvpn/forward.c
M src/openvpn/forward.h
M src/openvpn/mtcp.c
M src/openvpn/mudp.c
M src/openvpn/multi.c
M src/openvpn/multi.h
12 files changed, 299 insertions(+), 242 deletions(-)
src/openvpn/dco.h +4 -3
@@ -128,12 +128,13 @@void close_tun_dco (struct tuntap *tt,openvpn_net_ctx_t *ctx);/** -* Read data from the DCO communication channel (i.e. a control packet) +* Read and process data from the DCO communication channel +* (i.e. a control packet) * * @param dco the DCO context * @return 0 on success or a negative error code otherwise */ -int dco_do_read (dco_context_t *dco); +int dco_read_and_process (dco_context_t *dco);/** * Install a DCO in the main event loop
@@ -300,7 +301,7 @@ }static inline int -dco_do_read (dco_context_t *dco) +dco_read_and_process (dco_context_t *dco) {ASSERT (false);return 0 ;
src/openvpn/dco_freebsd.c +43 -23
112 lines not on this page · raw message
src/openvpn/dco_freebsd.h +3 -2
@@ -33,6 +33,8 @@typedef enum ovpn_key_cipher dco_cipher_t ;enum ovpn_message_type_t { +/* message type #0 is treated as magic number by process_incoming_dco() */ +OVPN_CMD_NO_MESSAGE =0 ,OVPN_CMD_DEL_PEER ,OVPN_CMD_PACKET ,OVPN_CMD_SWAP_KEYS ,
@@ -57,9 +59,8 @@int dco_message_peer_id;int dco_del_peer_reason;struct sockaddr_storage dco_float_peer_ss; + struct context *c; -uint64_t dco_read_bytes; - uint64_t dco_write_bytes; } dco_context_t;#endif /* defined(ENABLE_DCO) && defined(TARGET_FREEBSD) */
src/openvpn/dco_linux.c +225 -178
569 lines not on this page · raw message
src/openvpn/dco_linux.h +1 -2
@@ -44,6 +44,7 @@int status;struct context *c; +int ctrlid;enum ovpn_mode ifmode;
@@ -55,8 +56,6 @@int dco_message_type;int dco_message_peer_id; int dco_del_peer_reason; -uint64_t dco_read_bytes; - uint64_t dco_write_bytes; } dco_context_t;#endif /* defined(ENABLE_DCO) && defined(TARGET_LINUX) */
src/openvpn/dco_win.c +1 -1
@@ -423,7 +423,7 @@ }int -dco_do_read (dco_context_t *dco) +dco_read_and_process (dco_context_t *dco) {/* no-op on windows */ ASSERT (0 );
src/openvpn/forward.c +6 -6
@@ -1269,13 +1269,11 @@ } } -static void -process_incoming_dco (struct context *c) +void +process_incoming_dco (dco_context_t *dco) {#if defined(ENABLE_DCO ) && (defined(TARGET_LINUX ) || defined(TARGET_FREEBSD )) -dco_context_t *dco = &c->c1.tuntap->dco; - -dco_do_read (dco); +struct context *c = dco->c;/* FreeBSD currently sends us removal notifcation with the old peer-id in * p2p mode with the ping timeout reason, so ignore that one to not shoot
@@ -1291,6 +1289,8 @@switch (dco->dco_message_type) {case OVPN_CMD_DEL_PEER : +/* peer is gone, unset ID to prevent more kernel calls */ + c->c2.tls_multi->dco_peer_id =-1 ;if (dco->dco_del_peer_reason ==OVPN_DEL_PEER_REASON_EXPIRED ) { msg(D_DCO_DEBUG, "%s: received peer expired notification of for peer-id "
@@ -2344,7 +2344,7 @@ {if (!IS_SIG (c)) { -process_incoming_dco (c); +dco_read_and_process (&c->c1.tuntap->dco); } } }
src/openvpn/forward.h +7 -0
@@ -50,6 +50,7 @@#include "openvpn.h" #include "occ.h" #include "ping.h" +#include "dco.h" #define IOW_TO_TUN (1<<0)#define IOW_TO_LINK (1<<1)
@@ -248,6 +249,12 @@*/ void process_incoming_tun (struct context *c); +/** +* Process an incoming DCO message (from kernel space). +* +* @param dco - Pointer to the structure representing the DCO context. +*/ +void process_incoming_dco (dco_context_t *dco);/** * Write a packet to the virtual tun/tap network interface.
src/openvpn/mtcp.c +1 -1
@@ -747,7 +747,7 @@/* incoming data on DCO? */ else if (e->arg == MTCP_DCO) { -multi_process_incoming_dco (m); +dco_read_and_process (&m->top.c1.tuntap->dco); }#endif /* signal received? */
src/openvpn/mudp.c +1 -5
@@ -409,11 +409,7 @@ {if (!IS_SIG (&m->top)) { -bool ret = true; -while (ret) - { - ret =multi_process_incoming_dco (m); - } +dco_read_and_process (&m->top.c1.tuntap->dco); } }#endif
src/openvpn/multi.c +5 -15
@@ -3287,20 +3287,17 @@* installed, and we do not need to clean up the state in the kernel */ mi->context.c2.tls_multi->dco_peer_id =-1 ; mi->context.sig->signal_text = reason; - mi->context.c2.dco_read_bytes = dco->dco_read_bytes; - mi->context.c2.dco_write_bytes = dco->dco_write_bytes;multi_signal_instance (m, mi,SIGTERM ); } -bool -multi_process_incoming_dco (struct multi_context *m) +void +multi_process_incoming_dco (dco_context_t *dco) { -dco_context_t *dco = &m->top.c1.tuntap->dco; +ASSERT (dco->c->multi); +struct multi_context *m = dco->c->multi;struct multi_instance *mi =NULL ; -int ret =dco_do_read (&m->top.c1.tuntap->dco); -int peer_id = dco->dco_message_peer_id;/* no peer-specific message delivered -> nothing to process.
@@ -3308,7 +3305,7 @@*/ if (peer_id <0 ) { -return ret >0 ; +return ; }if ((peer_id < m->max_clients) && (m->instances[peer_id]))
@@ -3355,13 +3352,6 @@"type %d, del_peer_reason %d" , peer_id, dco->dco_message_type, dco->dco_del_peer_reason); } - - dco->dco_message_type =0 ; - dco->dco_message_peer_id =-1 ; - dco->dco_del_peer_reason =-1 ; - dco->dco_read_bytes =0 ; - dco->dco_write_bytes =0 ; -return ret >0 ; }#endif /* if defined(ENABLE_DCO) && defined(TARGET_LINUX) */
src/openvpn/multi.h +2 -6
@@ -317,13 +317,9 @@/** * Process an incoming DCO message (from kernel space). * -* @param m - The single \c multi_context structur.e -* -* @return -* - True, if the message was received correctly. -* - False, if there was an error while reading the message. +* @param dco - The DCO context containing the parsed message. */ -bool multi_process_incoming_dco (struct multi_context *m); +void multi_process_incoming_dco (dco_context_t *dco);/**************************************************************************/ /**
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1632?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: openvpn
Gerrit-Branch: release/2.6
Gerrit-Change-Id: I92c5f74a27b40fede204f714b042a6cc80b3703e
Gerrit-Change-Number: 1632
Gerrit-PatchSet: 3
Gerrit-Owner: ralf_lici <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>